Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply black format #170

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Apply black format #170

merged 5 commits into from
Jul 10, 2024

Conversation

ylyangtw
Copy link
Contributor

No description provided.

@ylyangtw ylyangtw linked an issue Jun 18, 2024 that may be closed by this pull request
Apply Black formatter #169
Closed
@ylyangtw ylyangtw marked this pull request as draft June 18, 2024 19:20
@ylyangtw ylyangtw marked this pull request as ready for review June 21, 2024 18:49
@navarroc
Copy link
Member

navarroc commented Jul 9, 2024

Just an FYI - the fix for pytest is in mine and @ywkim312 's PR here - #172. If we merge that first, we can then bring that into this PR.

navarroc
navarroc requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@navarroc navarroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit run --all-files fails - unused import in geoutil.py

@ylyangtw
Copy link
Contributor Author

pre-commit run --all-files fails - unused import in geoutil.py

it's addressed!

ywkim312
ywkim312 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@ywkim312 ywkim312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test worked well

@ywkim312 ywkim312 merged commit 80f00a0 into develop Jul 10, 2024
8 checks passed
@ywkim312 ywkim312 deleted the 169-apply-black-formatter branch July 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navarroc navarroc navarroc approved these changes

@ywkim312 ywkim312 ywkim312 approved these changes

@longshuicy longshuicy Awaiting requested review from longshuicy

@Rashmil-1999 Rashmil-1999 Awaiting requested review from Rashmil-1999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply Black formatter
3 participants
@ylyangtw @navarroc @ywkim312